fix(TYP-2386): Pass hidden fields via fragment #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
maxprilutskiy
approved these changes
Jun 30, 2020
demo/demo.js
Outdated
| // embed.setAttribute(attribute, addQueryStringToUrl(embedAttr, queryString)) | ||
| // }) | ||
| // }) | ||
| // }) |
There was a problem hiding this comment.
Does it make sense to remove commented lines entirely?
There was a problem hiding this comment.
Yes, I will remove it!
lfons
approved these changes
Jun 30, 2020
Pass hidden fields to typeform using both query params (legacy) and fragment (new approach)
|
[BOT] Preview available: https://embed.typeform.com/5c3b9aa9ee623fc101b5c3cad7c0c4ceeac74f77/embed.js |
maxprilutskiy
approved these changes
Jul 1, 2020
travis-tf
pushed a commit
that referenced
this pull request
Jul 1, 2020
## [0.22.1](v0.22.0...v0.22.1) (2020-07-01) ### Bug Fixes * **TYP-2386:** Pass hidden fields via fragment ([#50](#50)) ([0b611b9](0b611b9))
|
🎉 This PR is included in version 0.22.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report: TYP-2386
Bug introduced in DIST-241 by changing passing of hidden fields from query param to fragment.